#141680: "incorrect score display"
Sobre qué é este informe?
Qué aconteceu? Por favor selecciona debaixo
Qué aconteceu? Por favor selecciona debaixo
Por favor revisa se xa hai un informe sobre o mesmo tema
De ser afirmativo, por favor VOTA por este informe. Aos informes con máis votos se lles da PRIORIDADE!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Descrición detallada
-
• Por favor, copia e pega a mensaxe de erro que ves na túa pantalla, se houbera algún.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Por favor, explica o que querías facer, o que fixeche e o que pasou
• Cal é o teu navegador?
opera
-
• Por favor, copia/pega o texto amosado en inglés no canto do teu idioma. Se tes un pantallazo deste erro (boa práctica), podes usar Imgur.com para subilo e copiar/pegar a ligazón aquí.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• É este o texto dispoñible no sistema de tradución? Se é así, foi traducido fai máis de 24 horas?
• Cal é o teu navegador?
opera
-
• Por favor explica a túa suxestión de maneira precisa e concisa para que sexa o máis sinxelo posible entender o que queres dicir.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Cal é o teu navegador?
opera
-
• Qué había na pantalla cando se quedou bloqueado? (mensaxe de erro?, pantalla en blanco?, unha parte da interface do xogo?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Cal é o teu navegador?
opera
-
• Qué parte das regras non se cumpriron na adaptación da BGA?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• é visible a violación das regras na repetición? Se o é, en que número de movemento?
• Cal é o teu navegador?
opera
-
• Qué acción de xogo querías realizar?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Qué é o que tratache de facer para activar esta acción do xogo?
-
• Qué sucedeu cando o fixeche (a mensaxe de erro, mensaxe na barra de estado do xogo, ...)?
• Cal é o teu navegador?
opera
-
• En que paso do xogo ocorreu o problema (cal foi a instrucción actual do xogo)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Qué sucedeu cando tratache de facer unha acción de xogo (mensaxe de erro, mensaxe na barra de estado do xogo, ...)?
• Cal é o teu navegador?
opera
-
• Por favor, describe o problema de visualización. Se tes un pantallazo deste erro (boa práctica), podes usar Imgur.com para subilo e copiar/pegar a ligazón aquí.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Cal é o teu navegador?
opera
-
• Por favor, copia/pega o texto amosado en inglés no canto do teu idioma. Se tes un pantallazo deste erro (boa práctica), podes usar Imgur.com para subilo e copiar/pegar a ligazón aquí.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• É este o texto dispoñible no sistema de tradución? Se é así, foi traducido fai máis de 24 horas?
• Cal é o teu navegador?
opera
-
• Por favor explica a túa suxestión de maneira precisa e concisa para que sexa o máis sinxelo posible entender o que queres dicir.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Cal é o teu navegador?
opera
Historial de informes
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Engade a este informe
- Outro DI de mesa / ID de movemento
- Premer F5 resolveu o problema?
- Apareceu o problema varias veces? Tódalas veces? Aleatoriamente?
- Se tes un pantallazo deste erro (boa práctica), podes usar Imgur.com para subilo e copiar/pegar a ligazón aquí.
